Merged
Conversation
xingyu4j
requested review from
a team,
anncwb,
jinmao88,
mynetfan and
vince292007
as code owners
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughCentralizes Tailwind theme into a new internal package Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/src/en/guide/project/tailwindcss.md (1)
12-18:⚠️ Potential issue | 🟡 MinorDocumentation references outdated location for Tailwind directives.
Similar to the Chinese documentation, line 12 states directives are in
global.css, butglobal.cssnow only contains an import. The actual directives are intheme.css.-In `global.css`, you will see the Tailwind CSS v4 directives currently used by the project, such as: +In `theme.css`, you will see the Tailwind CSS v4 directives currently used by the project, such as:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/src/en/guide/project/tailwindcss.md` around lines 12 - 18, Update the documentation text in tailwindcss.md to point readers to theme.css instead of global.css: replace the sentence that says directives are in `global.css` with one that explains `global.css` only contains an import and the actual Tailwind CSS v4 directives (`@source`, `@custom-variant`, `@theme`, `@theme inline`, `@utility`) live in `theme.css`, and adjust any nearby references or examples that assume `global.css` contains those directives.docs/src/guide/project/tailwindcss.md (1)
12-18:⚠️ Potential issue | 🟡 MinorDocumentation references outdated location for Tailwind directives.
Line 12 states directives are in
global.css, but after this PR,global.cssonly contains@import '@vben/tailwind-config/theme'. The actual directives (@source,@custom-variant,@theme,@utility) now reside ininternal/tailwind-config/src/theme.css.Consider updating this section to reference
theme.cssinstead:-在 `global.css` 中你会看到当前项目使用的 Tailwind CSS v4 指令，例如： +在 `theme.css` 中你会看到当前项目使用的 Tailwind CSS v4 指令，例如：🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/src/guide/project/tailwindcss.md` around lines 12 - 18, Update the documentation to point readers to the new location of the Tailwind directives: replace the reference to `global.css` with `internal/tailwind-config/src/theme.css` and note that `global.css` now only contains `@import '@vben/tailwind-config/theme'`; explicitly list the directives (`@source`, `@custom-variant`, `@theme`, `@theme inline`, `@utility`) as residing in `theme.css` so readers are directed to the correct file (look for mentions of `global.css` and the directive list in this guide and change them to reference `internal/tailwind-config/src/theme.css` and the import behavior).
🧹 Nitpick comments (1)
packages/@core/base/design/src/css/nprogress.css (1)
43-61: Duplicate@keyframesdefinition.The
@keyframes nprogress-spinneris defined twice (lines 43-51 and 53-61). This appears to be pre-existing but could be cleaned up.♻️ Remove duplicate keyframes
`@keyframes` nprogress-spinner { 0% { transform: rotate(0deg); } 100% { transform: rotate(360deg); } } - -@keyframes nprogress-spinner { - 0% { - transform: rotate(0deg); - } - - 100% { - transform: rotate(360deg); - } -}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/`@core/base/design/src/css/nprogress.css around lines 43 - 61, Remove the duplicate `@keyframes` nprogress-spinner definition: keep a single nprogress-spinner keyframes block and delete the repeated one so there aren’t two identical `@keyframes` rules; ensure the remaining `@keyframes` nprogress-spinner preserves the rotate(0deg) to rotate(360deg) animation and that any CSS referring to nprogress-spinner continues to work.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@docs/src/en/guide/project/tailwindcss.md`:
- Around line 12-18: Update the documentation text in tailwindcss.md to point
readers to theme.css instead of global.css: replace the sentence that says
directives are in `global.css` with one that explains `global.css` only contains
an import and the actual Tailwind CSS v4 directives (`@source`,
`@custom-variant`, `@theme`, `@theme inline`, `@utility`) live in `theme.css`,
and adjust any nearby references or examples that assume `global.css` contains
those directives.
In `@docs/src/guide/project/tailwindcss.md`:
- Around line 12-18: Update the documentation to point readers to the new
location of the Tailwind directives: replace the reference to `global.css` with
`internal/tailwind-config/src/theme.css` and note that `global.css` now only
contains `@import '@vben/tailwind-config/theme'`; explicitly list the directives
(`@source`, `@custom-variant`, `@theme`, `@theme inline`, `@utility`) as
residing in `theme.css` so readers are directed to the correct file (look for
mentions of `global.css` and the directive list in this guide and change them to
reference `internal/tailwind-config/src/theme.css` and the import behavior).
---
Nitpick comments:
In `@packages/`@core/base/design/src/css/nprogress.css:
- Around line 43-61: Remove the duplicate `@keyframes` nprogress-spinner
definition: keep a single nprogress-spinner keyframes block and delete the
repeated one so there aren’t two identical `@keyframes` rules; ensure the
remaining `@keyframes` nprogress-spinner preserves the rotate(0deg) to
rotate(360deg) animation and that any CSS referring to nprogress-spinner
continues to work.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b15cc79b-4c11-4657-9364-a40befe711c4
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (23)
.vscode/settings.jsondocs/package.jsondocs/src/en/guide/project/tailwindcss.mddocs/src/guide/project/tailwindcss.mdinternal/lint-configs/oxlint-config/src/configs/tailwindcss.tsinternal/tailwind-config/package.jsoninternal/tailwind-config/src/index.tsinternal/tailwind-config/src/theme.cssinternal/vite-config/src/plugins/tailwind-reference.tspackage.jsonpackages/@core/base/design/package.jsonpackages/@core/base/design/src/css/global.csspackages/@core/base/design/src/css/nprogress.csspackages/@core/ui-kit/menu-ui/src/components/normal-menu/normal-menu.vuepackages/@core/ui-kit/shadcn-ui/src/assets/index.csspackages/@core/ui-kit/shadcn-ui/src/components/breadcrumb/breadcrumb-background.vuepackages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vuepackages/effects/common-ui/src/components/cropper/cropper.vuepackages/effects/layouts/src/widgets/theme-toggle/theme-button.vuepackages/effects/plugins/src/vxe-table/style.csspnpm-workspace.yamlscripts/vsh/src/check-dep/index.tsvben-admin.code-workspace
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
playground/src/views/examples/form/basic.vue (1)
368-370: Questionable log level change:console.info→console.warn.This change appears unrelated to the PR's objective (tailwindcss config fix). Additionally,
console.warnis semantically intended for potential problems or cautionary messages, whereas logging a normal drag-sort operation is purely informational. Consider reverting toconsole.info, or removing this debug logging entirely if it was added temporarily.🔧 Suggested revert
onDragSort: (oldIndex: number, newIndex: number) => { - console.warn(`图片从 ${oldIndex} 移动到 ${newIndex}`); + console.info(`图片从 ${oldIndex} 移动到 ${newIndex}`); },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@playground/src/views/examples/form/basic.vue` around lines 368 - 370, The onDragSort handler currently uses console.warn for a normal informational event (function onDragSort: (oldIndex: number, newIndex: number) => { ... }), which is semantically incorrect and unrelated to the PR; change the console.warn back to console.info (or remove the debug statement entirely) so that the drag-sort message is logged at an informational level or not logged in production. Ensure you update the onDragSort callback accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@playground/src/views/examples/form/basic.vue`:
- Around line 368-370: The onDragSort handler currently uses console.warn for a
normal informational event (function onDragSort: (oldIndex: number, newIndex:
number) => { ... }), which is semantically incorrect and unrelated to the PR;
change the console.warn back to console.info (or remove the debug statement
entirely) so that the drag-sort message is logged at an informational level or
not logged in production. Ensure you update the onDragSort callback accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2b4889a8-a033-4162-82b0-a2a7cc30d8ab
📒 Files selected for processing (2)
internal/lint-configs/eslint-config/src/configs/node.tsplayground/src/views/examples/form/basic.vue
5 tasks
…n-admin into fix-tailwindcss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit
Chores
Refactor
Documentation
Bug Fixes